Be more specific about which icon uenvs are xfail in UenvFixincludes test#622
Open
msimberg wants to merge 2 commits into
Open
Be more specific about which icon uenvs are xfail in UenvFixincludes test#622msimberg wants to merge 2 commits into
msimberg wants to merge 2 commits into
Conversation
Contributor
Author
|
cscs-ci run alps-santis-uenv;CSCS_RFM_UENV=icon/25.2:v1,icon/25.2:v3,icon/25.2:v4,icon/26.7:v1,icon-dsl/25.12:v1,icon-dsl/25.12:v2,icon-wcp/v1:rc4 |
Contributor
Author
|
cscs-ci run alps-santis-uenv;CSCS_RFM_UENV=icon/26.7:v1 |
Contributor
Author
|
cscs-ci run alps-santis-uenv;CSCS_RFM_UENV=icon-dsl/25.12:v2 |
msimberg
commented
Jul 15, 2026
Contributor
Author
|
cscs-ci run alps-santis-uenv;CSCS_RFM_UENV=icon-dsl/25.12:v2 |
Contributor
Author
|
cscs-ci run alps-santis-uenv;CSCS_RFM_UENV=icon/26.7:v1 |
Contributor
Author
|
Now it's correctly xfailing: https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/6557018579987861/835515875116212/-/jobs/15361826177#L94. I was locally replacing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest icon uenv now passes the UenvFixincludes test, so the test was XPASSing at the latest maintenance reframe run. This PR updates the xfail condition to specifically xfail only the icon* uenvs that should be xfailed. New versions of the icon uenvs are not automatically xfailed anymore.
Tested on santis with
CSCS_RFM_UENV=icon/25.2:v1,icon/25.2:v3,icon/25.2:v4,icon/26.7:v1,icon-dsl/25.12:v1,icon-dsl/25.12:v2,icon-wcp/v1:rc4 reframe -C $PWD/config/cscs.py --system santis -c checks/prgenv/uenv_fixincludes.py --run.